AO3-6204 Allow certain admins to remove non-default orphan pseuds from orphaned works #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pseuds = Pseud.find(pseuds).select { |p| p.user_id == orphan_account.id } | ||
| end | ||
|
|
||
| orphan_pseud = orphan_account.default_pseud |
There was a problem hiding this comment.
You can inline this variable since it's only used once.
There was a problem hiding this comment.
It's used multiple times in the loop if multiple pseuds are removed. I want to avoid the DB lookup/cache hit in the loop.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
redsummernight
approved these changes
Feb 22, 2025
redsummernight
added
Reviewed: Ready to Merge
and removed
Coder Has Actioned Review
labels
Bilka2
deleted the
AO3-6204-allow-to-remove-non-default-orphan-pseuds-from-orphaned-works
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6204
Purpose
Adds a button and a confirmation page to allow some admins to remove non-default orphan_account pseuds from orphaned works.
References
PR Limit: 8 out of 5
Using reviewer bonus:
#4378
#4885
Credit
Bilka