Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5498 AO3-931 Show placeholder for deleted invitee #5000

Merged
merged 9 commits into from
Mar 11, 2025

Conversation

brianjaustin
Copy link
Member

@brianjaustin brianjaustin commented Dec 21, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-931 (yes, that's a real ticket number 😅 )

Purpose

When a user sends an invitation, someone accepts it, and then the invitee deletes their account, show the old invitee as a placeholder (suggested by PAC/Support elsewhere):

invitations list view with deleted user placeholder

invitation detail with deleted user placeholder

Side note: the invitation detail page is... a bit confusing as-is. I'm OK using this story to update that if we want, but I haven't done that on my own for a number of reasons.

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these days, I will hit the right button on my review comments. One of them! (And no other.)

@sarken
Copy link
Collaborator

sarken commented Jan 3, 2025

Oh, hey, this is actually the updated version of the issue you worked on: https://otwarchive.atlassian.net/issues/AO3-5498

Would you like to grab that and finish it off?

@brianjaustin
Copy link
Member Author

Sure!

@brianjaustin brianjaustin changed the title AO3-931 Show placeholder for deleted invitee AO3-5498 AO3-931 Show placeholder for deleted invitee Jan 13, 2025
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts, but otherwise looks good!

@sarken sarken merged commit 35b3366 into otwcode:master Mar 11, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants