AO3-6775 Add delete work mailer preview #4948
Conversation
weeklies
changed the title
weeklies
changed the title
|
The simplest example for a test for localised emails is likely the feature test included in #4921. Let me know if you have further questions! |
|
|
||
| work = create(:work, authors: [first_creator.default_pseud, second_creator.default_pseud]) | ||
|
|
||
| User.current_user = second_creator |
There was a problem hiding this comment.
This is a possible way to do it, but it feels a bit hacky. What do you think about instead pulling the self vs other check out of the mailer erb files into work.rb and only passing the result into the mailer method? Then you could specify directly in the method call whether it's the self or other version.
| @@ -40,6 +40,21 @@ def claim_notification_registered | |||
| UserMailer.claim_notification(creator_id, [work.id], true) | |||
| end | |||
|
|
|||
| def delete_work | |||
There was a problem hiding this comment.
| def delete_work | |
| def delete_work_notification_self |
and adjust the other method name to match, please. Translation would like the preview names to be the mailer names with a suffix for the variant
| end | ||
| mail( | ||
| to: user.email, | ||
| subject: t('user_mailer.delete_work_notification.subject', app_name: ArchiveConfig.APP_SHORT_NAME) |
There was a problem hiding this comment.
It'd be nice if you could replace this with default_i18n_subject
|
Another example for a cucumber test for the email translations is now available with #4959. It shows something that would be nice to have: Generating emails for two users at once, one translated and one non-translated. For work deletions that should be achievable by deleting a work with multiple creators. |
|
Putting this up for adoption, since I've been busy. |
Issue
https://otwarchive.atlassian.net/browse/AO3-6775
Not sure how to test this with the feature test changes, and I would appreciate some direction.
Purpose
Add delete work mailer preview.
Testing Instructions
See Jira issue.