forked from flutter/plugins
-
Notifications
You must be signed in to change notification settings - Fork 5
Update master #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hint is only valid in the network path.
* Rename instrumentation_adapter plugin to e2e plugin * Refactored test, demonstrate reading the exit code * Updated README
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS. - Define the module by setting `DEFINES_MODULE` in the podspec. See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/). - Explicitly set `VALID_ARCHS` to x86_64 for the simulator. See CocoaPods/CocoaPods#9210. - Add mechanism to skip dummy multi-platform podspecs so url_launcher_web could be skipped during lint script.
Migrate android intent to the new embedding. - Refactors the existing plugin logic into two new classes. - Adds an implementation of the plugin for the new embedding. - Adds a unit test.
The previous minimum was too low to support the V2 embedding at compile time. The latest stable appears to be the oldest version that works with the plugin.
This depends on a new bugfix on the engine for text input to work with the new embedding (flutter/engine#13015).
* Support the v2 Android embedder. * Print a warning if the plugin is not registered. * Updated method channel name. * Set a Flutter minimum SDK version.
Migrates the camera plugin to the new embedding and adds an example activity exercising it. Unlike some of the previous PRs on this, this is the minimal migration that would land this without adding any tech debt. From previous offline discussions we'd like to scope these migrations to the bare minimum required to keep the patches small. See #2114 for a migration combined with a refactoring. That said there are still some minor changes to prevent this from adding additional tech debt, going a little beyond #2118: - `#onMethodCall` has been split up into its own `MethodCallHandlerImpl` class to try and keep `CameraPlugin` from mixing concerns. Before the migration, _all_ it was doing was responding to method calls. Now there's a significant amount of logic just based around responding to lifecycle events. It still seemed better to split that into a separate file than to try and manage that logic all in one place. Other than the above refactor, the original logic is untouched.
Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in build.gradle to support apps that has not been migrated to AndroidX.
Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in build.gradle to support apps that has not been migrated to AndroidX.
After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx. This patch removes the constraint.
We introduced a constraint that the app uses the plugin has to be migrated to androidx. This patch removes the constraint.
We introduced a constraint that the app uses the plugin has to be migrated to androidx. This patch removes the constraint.
* [url_launcher] Add overridable platform * Fix analyzer lints * Run dartfmt * Add a url_launcher_platform_interface package * Disable tests temporarily * Add license header * Fix typo in test * Add LICENSE file * Respond to review comments * Respond to review comments
Fail setting `UrlLauncherPlatform.instance` to something that `implements` (rather than `extends`) `UrlLauncherPlatform`.
I'm not bumping the major version as the breaking change policy for platform interface is that we're only guaranteeing to not break classes that `extend` it.
We leave a backdoor for mockito mocks which can do:
```dart
class MockUrlLauncherPlatform extends Mock
implements UrlLauncherPlatform {}
test('', () {
MockUrlLauncherPlatform mock = MockUrlLauncherPlatform();
when(mock.isMock).thenReturn(true);
UrlLauncherPlatform.instance = mock;
}
```
Fixes possible version conflict issues. This would cause runtime class not found errors if any of these plugins relied on `Lifecycle` at runtime, but they do not. Test is pending in flutter/plugin_tools#62.
* Update README
…on is left or right (#2070)
… NSInteger as %ld format warnings. (#2242)
#2239) Existing behaviour creates a request which prioritizes image quality over frame rate and results in a choppy and / or freezing streaming session on many devices. Creating a request suitable for video recording means that a stable frame rate is used, and post-processing is set for recording quality. It noticeably improves streaming images on a variety of devices.
… to 5.0 (#2127) * Fix Deprecated API Usage issue * Update to 5.0 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.