Skip to content

Conversation

@otopba
Copy link
Owner

@otopba otopba commented Nov 2, 2019

No description provided.

Harry Terkelsen and others added 30 commits October 7, 2019 09:14
This hint is only valid in the network path.
* Rename instrumentation_adapter plugin to e2e plugin
* Refactored test, demonstrate reading the exit code
* Updated README
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS.
- Define the module by setting `DEFINES_MODULE` in the podspec.  See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/).
- Explicitly set `VALID_ARCHS` to x86_64 for the simulator.  See CocoaPods/CocoaPods#9210.
- Add mechanism to skip dummy multi-platform podspecs so url_launcher_web could be skipped during lint script.
Migrate android intent to the new embedding.

- Refactors the existing plugin logic into two new classes.
- Adds an implementation of the plugin for the new embedding.
- Adds a unit test.
The previous minimum was too low to support the V2 embedding at compile
time. The latest stable appears to be the oldest version that works with
the plugin.
This depends on a new bugfix on the engine for text input to work with
the new embedding (flutter/engine#13015).
* Support the v2 Android embedder.
* Print a warning if the plugin is not registered.	
* Updated method channel name.
* Set a Flutter minimum SDK version.
Migrates the camera plugin to the new embedding and adds an example
activity exercising it.

Unlike some of the previous PRs on this, this is the minimal migration
that would land this without adding any tech debt. From previous offline
discussions we'd like to scope these migrations to the bare minimum
required to keep the patches small. See #2114 for a migration combined
with a refactoring.

That said there are still some minor changes to prevent this from adding
additional tech debt, going a little beyond #2118:

- `#onMethodCall` has been split up into its own `MethodCallHandlerImpl`
class to try and keep `CameraPlugin` from mixing concerns. Before the
migration, _all_ it was doing was responding to method calls. Now
there's a significant amount of logic just based around responding to
lifecycle events. It still seemed better to split that into a separate
file than to try and manage that logic all in one place.

Other than the above refactor, the original logic is untouched.
Chris Yang and others added 29 commits October 18, 2019 15:26
Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in build.gradle to support apps that has not been migrated to AndroidX.
Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in build.gradle to support apps that has not been migrated to AndroidX.
After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.
We introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.
We introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.
* [url_launcher] Add overridable platform

* Fix analyzer lints

* Run dartfmt

* Add a url_launcher_platform_interface package

* Disable tests temporarily

* Add license header

* Fix typo in test

* Add LICENSE file

* Respond to review comments

* Respond to review comments
Fail setting `UrlLauncherPlatform.instance` to something that `implements` (rather than `extends`) `UrlLauncherPlatform`.

I'm not bumping the major version as the breaking change policy for platform interface is that we're only guaranteeing to not break classes that `extend` it.

We leave a backdoor for mockito mocks which can do:
```dart
class MockUrlLauncherPlatform extends Mock
    implements UrlLauncherPlatform {}

test('', () {
  MockUrlLauncherPlatform mock = MockUrlLauncherPlatform();
  when(mock.isMock).thenReturn(true);
  UrlLauncherPlatform.instance = mock;
}
```
…2228)

* [url_launcher] Use `url_launcher_platform_interface` to handle calls

* Exclude platform interface from all-plugins-app

* Update now that #2230 has landed
Fixes possible version conflict issues. This would cause runtime class not found errors if any of these plugins relied on `Lifecycle` at runtime, but they do not.

Test is pending in flutter/plugin_tools#62.
)

* [url_launcher] Migrate url_launcher_web to the platform interface

* Fix analyzer errors

* Add doc comments
#2239)

Existing behaviour creates a request which prioritizes image quality over frame rate and results in a choppy and / or freezing streaming session on many devices. Creating a request suitable for video recording means that a stable frame rate is used, and post-processing is set for recording quality. It noticeably improves streaming images on a variety of devices.
… to 5.0 (#2127)

* Fix Deprecated API Usage issue
* Update to 5.0 compatibility
@otopba otopba merged commit 485a419 into otopba:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.