Don't try to generate code for network operations and improve generated variable and method names#1
Merged
osulacam merged 2 commits intoosulacam:DataModelfrom Sep 9, 2016
Conversation
Variables and methods no longer have numbers if there's only one of that operation, or if an operation only has one output. Operations with multiple outputs have the outputs named the same as on the socket (instead of just 'output0', 'output1', ...) Rename `MutableOf` to `Ref` because it's really just holding a reference and it's used similarly to output parameters in C/C++
SamCarlberg
changed the title
Author
|
I'm not running tests on my machine until OpenCV artifacts get into the maven repo. Everything seems to work fine but there's some edge cases for generated input variables in C++ that I'm not sure will get the correct names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code generation no longer breaks when there are publishing operations in the pipeline