Skip to content

Comments

update to sh4lt 0.2.0#1928

Merged
jcelerier merged 4 commits intoossia:masterfrom
nicobou:master
Jan 11, 2026
Merged

update to sh4lt 0.2.0#1928
jcelerier merged 4 commits intoossia:masterfrom
nicobou:master

Conversation

@nicobou
Copy link
Contributor

@nicobou nicobou commented Jan 9, 2026

No description provided.

@nicobou
Copy link
Contributor Author

nicobou commented Jan 9, 2026

salut ! so it builds, but after some testing, there is at least on fix to add. coming soon :p

@jcelerier
Copy link
Member

Ah merci pour le patch! Looks like it's just macos which does not support a flag:

Users/runner/work/score/score/3rdparty/sh4lt/sh4lt/ipcs/unix-socket-client.cpp:56:88: error: use of undeclared identifier 'MSG_CONFIRM'
56 | socket_.fd_, &proto_->quit_msg_, sizeof(proto_->quit_msg_), MSG_NOSIGNAL | MSG_CONFIRM);

Maybe it can be enabled only if(LINUX/BSD)?

@jcelerier jcelerier force-pushed the master branch 6 times, most recently from ff76fa0 to 1e41cd2 Compare January 9, 2026 22:06
@nicobou
Copy link
Contributor Author

nicobou commented Jan 10, 2026

Yes, Sh4lt now builds only on Linux (I think, but not sure since I could not test on OSX).
Also, I tested the update with GStreamer pipelines. So unless you see something else, it is ready for a merge.
Along this PR, an other PR in the Ossia doc fixes the GStreamer examples : ossia/score-docs#83

And thank @jcelerier for the great work !

@jcelerier jcelerier added this pull request to the merge queue Jan 11, 2026
Merged via the queue into ossia:master with commit f000317 Jan 11, 2026
49 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants