🌱 sort organizations in Contributors detail string #4436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes duplicated company found words, and sorted the output. the sorting is aimed at supporting cleaner diffs for scdiff. Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Member
Author
|
/scdiff generate Contributors |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 66.80% 68.54% +1.73%
==========================================
Files 230 240 +10
Lines 16602 17882 +1280
==========================================
+ Hits 11091 12257 +1166
- Misses 4808 4823 +15
- Partials 703 802 +99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
cleanup for scdiff
What is the current behavior?
The orgs are printed in map iteration order (random), and there's a lot of duplication in the text:
specifically with iteration order, this creates noisy
scdiffdiffs where the only difference is the order:What is the new behavior (if this is a feature change)?**
The strings are sorted, which will help create less noisy diffs when running
scdiff(like during the release process).Removed the duplicated "contributor org/company found" text which made the output long:
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)