Repository navigation
fix(OSPS-QA-06.01): ignore skipped and neutral check runs - #514
Merged
Merged
Conversation
HasOneOrMoreStatusChecks counted every check run on the default branch's last merged pull request, whatever its conclusion. If every run on that pull request was skipped, the step still reported "N status checks were run" and passed, even though nothing checked the change. Call executedStatusChecks, the helper OSPS-QA-03.01 already uses, so SKIPPED and NEUTRAL runs no longer count. A pull request whose runs were all skipped or neutral now fails with "No status checks were run". Failed, cancelled and unfinished runs still count, as before. Fixes ossf#510 Signed-off-by: Yashvardhan Thanvi <[email protected]>
Member
|
Closed and reopened PR to rekick checks. |
jmeridth
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510
HasOneOrMoreStatusChecks(OSPS-QA-06.01) counted every check run on the default branch's last merged pull request, whatever its conclusion. So a pull request where every run was skipped still passed with "N status checks were run".The step now uses
executedStatusChecks, the helper added in #509 for OSPS-QA-03.01.SKIPPEDandNEUTRALruns no longer count, so that case now fails with "No status checks were run". Failed, cancelled and unfinished runs still count, as in OSPS-QA-03.01.Testing: added
Test_HasOneOrMoreStatusCheckstosteps_test.go, using thegraphqlWithCheckRunshelper from #509. The three skip-related cases fail onmainand pass with this change.Overlap with #513: both edit
HasOneOrMoreStatusChecks. Whichever lands second should keep #513's guard and replace the loop with theexecutedStatusChecks(payload)call; the conflict is small.