Fix thermal camera topic mapping#776
Merged
adlarkin merged 1 commit intoadlarkin/add_thermal_camerafrom Feb 3, 2021
Merged
Conversation
Signed-off-by: Ian Chen <[email protected]>
|
Build finished. 21 tests run, 0 skipped, 1 failed. |
adlarkin
approved these changes
Feb 3, 2021
Contributor
adlarkin
left a comment
adlarkin
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fixes! Just one minor question below.
Also, do we need the optical frame publishers for the thermal camera, or can we leave them out?
submitted_models/marble_hd2_sensor_config_1/launch/vehicle_topics.launch
Show resolved
Hide resolved
Contributor
Author
Since they are also cameras that produce |
nkoenig
pushed a commit
that referenced
this pull request
Feb 11, 2021
* starting to add thermal camera to marble_hd2_sensor_config_1 Signed-off-by: Ashton Larkin <[email protected]> * add optical frame publisher, camera info topic, and more thermal camera sensor parameters Signed-off-by: Ashton Larkin <[email protected]> * fix topic mapping (#776) Signed-off-by: Ian Chen <[email protected]> * add thermal camera visual, fix location and textures Signed-off-by: Ashton Larkin <[email protected]> * update hfov assuming degrees in spec Signed-off-by: Ashton Larkin <[email protected]> * break out thermal camera addition to HD2 configs 3 and 4 Signed-off-by: Ashton Larkin <[email protected]> * set thermal default to 0 for HD2 vehicle_topics.launch Signed-off-by: Ashton Larkin <[email protected]> * New config with thermal camera: CERBERUS_M100_SENSOR_CONFIG_2 (#777) * adding thermal camera to cerberus m100 Signed-off-by: Ian Chen <[email protected]> * fix bridge Signed-off-by: Ian Chen <[email protected]> * update thermal camera spec Signed-off-by: Ian Chen <[email protected]> * new config_2 Signed-off-by: Ian Chen <[email protected]> * remove config_2 Signed-off-by: Ian Chen <[email protected]> * reuse config_1 files Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes so it works with the current thermal camera topic names
/imagesuffixfixing the topic names in ign-gazebo breaks existing behavior so using this workaround for now.
Signed-off-by: Ian Chen [email protected]