Remove boost::thread #1918
Merged
Remove boost::thread #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
|
Build origin/pr/1918/merge (Job: 2462) failed 👎 |
theopolis
force-pushed
the
remove_boost_threads
branch
from
53c9409 to
3de5284
Compare
|
Build origin/pr/1918/merge (Job: 2465) failed 👎 |
Member
Author
|
Merging this to rebuild Jenkins instances. This will break master for a few hours. After a merge we may need to recover the build with some regression fixes. These will occur within the next few hours and the build will stabilize before the EoD. It's most likely that external build hosts (and your local development checkout) will need some help. I promise to have documentation on how to port an existing CentOS, Ubuntu, and OS X build host. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
boost::threads withstd::threador the nativepthread. This also removesboost::mutexand the availability of a READ/WRITE lock. These locks are very complicated under the covers so a replacement of a simple mutex lock should be appropriate in most cases.