This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Overlay descendants without Context-dependecy that can be created in AsyncTask (again)#373
Merged
spyhunter99 merged 4 commits intoosmdroid:masterfrom Aug 17, 2016
k3b:master
Merged
Overlay descendants without Context-dependecy that can be created in AsyncTask (again)#373spyhunter99 merged 4 commits intoosmdroid:masterfrom k3b:master
spyhunter99 merged 4 commits intoosmdroid:masterfrom
k3b:master
Conversation
…. Polyline, Polygon, PathOverlay, OverlayWithIW, Overlay, NonAcceleratedOverlay, MapEventsOverlay, ItemizedOverlay
Made some basic overlays Context independant so they can be created in AsyncTask. Polyline, Polygon, PathOverlay, OverlayWithIW, Overlay, NonAcceleratedOverlay, MapEventsOverlay, ItemizedOverlay
k3b
changed the title
Collaborator
|
wow a lot of work. i had initially considered this approach with the 5.1 to 5.2 refactor. The scale bar was the only thing that uses the one field. I have no issues with the PR other than the scary commit message that says don't merge. @MKergall does this cause any issues from OBP? |
Collaborator
|
I don't see particular issues from OBP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a database with 18000 geo-positions (jpg-photos with exif-geo-info) that are displayed as clusters in a map.
Every time visible map area or the zoom level changes, the visible clusters are recalculted from the database:
An AsyncTask creates Clusterpoints (inherited from Overlay) and put them into a FolderOverlay.
When all visible Clusterpoints are calculated in the background, the FolderOverlay is added to the map.
Overlay and descendants can only be created in background task if they donot acces Android-Context.
Up to osmdroid-5.1 I used ResourceProxy for creating Overlays in AsyncTask.
Since Osmdroid-5.2 has removed ResourceProxy this merge request also removes Android-Context dependency from some Overlay descendants
so that these can be created in AsyncTask again.
These Overlay descendants are now Android-Context-free so they can be created in AsyncTask (outside main gui thread):
I deprecated the original constructors and created a new one without Context.
Old Osmdroid programs will get a deprecated compiler warning but should continue working.
This osmdroid issue relates to k3b/APhotoManager#59