Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

#1808 enable connectedCheck integration tests, migrate integration to under OpenStreetMaps instead of osmdroid-android-it#1809

Merged
spyhunter99 merged 5 commits intomasterfrom
feature/#1808
May 30, 2022
Merged

#1808 enable connectedCheck integration tests, migrate integration to under OpenStreetMaps instead of osmdroid-android-it#1809
spyhunter99 merged 5 commits intomasterfrom
feature/#1808

Conversation

@spyhunter99
Copy link
Copy Markdown
Collaborator

@spyhunter99 spyhunter99 commented May 25, 2022

hold to merge

…is will work however on device permissioins may still be an issue
…test failures that were artifacts of changing from the previous test configuration to this one, still have two test failures
@spyhunter99
Copy link
Copy Markdown
Collaborator Author

@monsieurtanuki do these look familiar?

org.osmdroid.tileprovider.modules.MapTileProviderTest > test_jump_queue[SM-G781U - 12] FAILED
java.lang.AssertionError: Three tiles in the list expected:<3> but was:<0>
at org.junit.Assert.fail(Assert.java:88)

org.osmdroid.tileprovider.modules.MapTileProviderTest > test_order[SM-G781U - 12] FAILED
java.lang.AssertionError: Three tiles in the list expected:<3> but was:<0>
at org.junit.Assert.fail(Assert.java:88)

@monsieurtanuki
Copy link
Copy Markdown
Collaborator

@spyhunter99 It doesn't look like a "bad luck" error with bad internet connection as it's local: here we're just testing the logic of queueing the tiles with fake tile source and tile provider.

Something fishy with the tile provider: max zoom level is set to 0, and we're requesting tiles of zoom levels 1, 2 and 3. Setting max level to 3 may fix that error.

@spyhunter99 spyhunter99 changed the title #1808 first attempt. i can't get any avd's up and running. i think th… #1808 enable connectedCheck integration tests, migrate integration to under OpenStreetMaps instead of osmdroid-android-it May 26, 2022
@spyhunter99
Copy link
Copy Markdown
Collaborator Author

that fixed the previous error, now DelayTest.testDelayOne is failing. I'm not sure what's going on here

@monsieurtanuki
Copy link
Copy Markdown
Collaborator

that fixed the previous error, now DelayTest.testDelayOne is failing. I'm not sure what's going on here

@spyhunter99 Could be that we're too precise with our tests and that in some cases when the computer is busy, the tests fail. My suggestion: add 1000ms to each hard-coded duration in DelayTest.

@spyhunter99
Copy link
Copy Markdown
Collaborator Author

@monsieurtanuki do these test code changes make sense? I'm not sure i understand what's going on here. maybe 10x is too much to have an effective test?

@spyhunter99 spyhunter99 merged commit c4338fa into master May 30, 2022
@monsieurtanuki
Copy link
Copy Markdown
Collaborator

@spyhunter99 The point here is not to be precise at the millisecond level, but just to ensure that the stack items are used in the expected order.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants