#1808 enable connectedCheck integration tests, migrate integration to under OpenStreetMaps instead of osmdroid-android-it#1809
Conversation
…is will work however on device permissioins may still be an issue
…test failures that were artifacts of changing from the previous test configuration to this one, still have two test failures
|
@monsieurtanuki do these look familiar? org.osmdroid.tileprovider.modules.MapTileProviderTest > test_jump_queue[SM-G781U - 12] FAILED org.osmdroid.tileprovider.modules.MapTileProviderTest > test_order[SM-G781U - 12] FAILED |
|
@spyhunter99 It doesn't look like a "bad luck" error with bad internet connection as it's local: here we're just testing the logic of queueing the tiles with fake tile source and tile provider. Something fishy with the tile provider: max zoom level is set to 0, and we're requesting tiles of zoom levels 1, 2 and 3. Setting max level to 3 may fix that error. |
|
that fixed the previous error, now DelayTest.testDelayOne is failing. I'm not sure what's going on here |
@spyhunter99 Could be that we're too precise with our tests and that in some cases when the computer is busy, the tests fail. My suggestion: add 1000ms to each hard-coded duration in |
|
@monsieurtanuki do these test code changes make sense? I'm not sure i understand what's going on here. maybe 10x is too much to have an effective test? |
|
@spyhunter99 The point here is not to be precise at the millisecond level, but just to ensure that the stack items are used in the expected order. |
hold to merge