This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Feature/#1776 build tech upgrades/build process improvements#1793
Merged
spyhunter99 merged 22 commits intomasterfrom May 5, 2022
Merged
Feature/#1776 build tech upgrades/build process improvements#1793spyhunter99 merged 22 commits intomasterfrom
spyhunter99 merged 22 commits intomasterfrom
Conversation
- dist zip is not hooked up - maven central publishing definitely needs to be redone, from scratch - mil-sym-android was on bintray but that is dead now, so if you attempt to build this branch, you'll check to check out and build that repo
updates 2525 renderer to a version that is on central
…OR AAR's ONLY) caveats, dependency declarations in the poms are done by parsing build.gradle files which is super risky considering the massive variations for writing them. exclusions aren't applied yet
…curity issues identifed by sonatype lift when publishing thus the many dependency updates. At this point, i think it's good enough for PR and hopefully for some assistance to resolving the on device unit testing stuff that's broken and the one or two unit tests that stopped working and is now commented out. Wiki release procedure document needs to be updated as well
# Conflicts: # gradle.properties
Collaborator
Author
…easons during the upgrades. seems to work ok now though
…incompatible for nearly 4 years now
…ill work with the newer android stuff adding in @hannesa2's github action scripts to ci osmdroid again
Contributor
|
There's a lot of code here to review (+2,310 −4,045). Is there any way to split it into more manageable chunks? I'm not going to have enough spare time to review a PR of this size any time soon, but I could review some smaller PRs as time allows. |
Collaborator
Author
|
well this has been open for 2 weeks, no comments one way or another. i'm inclined to just merge it and carry |
Collaborator
@spyhunter99 That sounds good. If needed there can fine-tunings after the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many have complained...and with good reason... for osmdroid's relatively ancient configuration for android build technologies. Including but not limited to:
The primary reasons for not upgrading where the following
In addition, osmdroid has a few other unique requirements
I've spent several long nights trying to get the latest AGP + Gradle to do everything we need it to do and failed. However...there is a happy story here. Most of the build tech that was previously in gradle fury was written in plain java so I was able to come up with a configuration and build process to satisfy all our requirements.
The release process, assuming this is merged, is follows:
What's in release.bat?
What does the release helper do?
Could the release helper be reworked to be in gradle?
What open issues are left?
Any other changes?