Only zoom in/out on ACTION_UP event#1775
Only zoom in/out on ACTION_UP event#1775monsieurtanuki merged 1 commit intoosmdroid:masterfrom hauke96:master
Conversation
monsieurtanuki
left a comment
monsieurtanuki
left a comment
There was a problem hiding this comment.
Thank you @hauke96!
|
I don't think my changes are the root cause of bug #1822 . I don't understand why a long-press event is fired anyway, the Simply reverting my PR will reintroduce the bug #1733, so I won't just undo my changes. Unfortunately I don't have the time to look into this right now. |
|
@hauke96 as I figure, your code changes the code where the zoom button decides to be responsible, not where the actual (at times doubled) zoom is being done. Thus, as the button claims not responsible, the one event you removed from detection, isn't captured and leaked to the next overlay. As buttons are often held, this can often result in LongPress events up the listener hierarchy. This is of course not happen for everyone, as many UIs might not respond at all to the resulting LongPress event. However for my app this messed up subsequent Osmdroid releases. Would be helpful, someone verified and hopefully pulled my pull request, so I can move back to master branch. @monsieurtanuki ? |
|
Oh, my projects run so unsmooth, I apologize. Yes, I mean pull #1876, @monsieurtanuki. osmdroid 6.1.17 still bugging for me. |
|
@InI4 Actually I'm not active on osmdroid anymore :-( |
Co-authored-by: frank <[email protected]>
4 participants
This fixes issue #1733. I tested this by building the osmdroid-android project and manually loading the resulting library into my app. The unwanted behavior described in #1733 is gone: Only one zoom takes place when I tap long on the zoom in or out button.