Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

bug/#1360 - refactored icon anchoring in MyLocationNewOverlay#1460

Merged
monsieurtanuki merged 3 commits intomasterfrom
bug/#1360
Sep 2, 2021
Merged

bug/#1360 - refactored icon anchoring in MyLocationNewOverlay#1460
monsieurtanuki merged 3 commits intomasterfrom
bug/#1360

Conversation

@monsieurtanuki
Copy link
Copy Markdown
Collaborator

@monsieurtanuki monsieurtanuki commented Dec 23, 2019

Impacted class:

  • MyLocationNewOverlay: created methods setPersonAnchor and setDirectionAnchor while deprecating method setPersonHotspot; created method setDirectionIcon for consistency while deprecating method setDirectionArrow; refactored the constructor accordingly

@monsieurtanuki
bug/#1360 - refactored icon anchoring in MyLocationNewOverlay
53bd752 
Impacted class:
* `MyLocationNewOverlay`: created methods `setPersonAnchor` and `setDirectionAnchor` while deprecating method `setPersonHotspot`; created method `setDirectionIcon` for consistency while deprecating method `setDirectionArrow`; refactored the constructor accordingly
@monsieurtanuki monsieurtanuki mentioned this pull request Dec 23, 2019
Open
@spyhunter99 spyhunter99 added this to the v6.1.7 milestone Mar 9, 2020
@spyhunter99
Copy link
Copy Markdown
Collaborator

spyhunter99 commented Jul 22, 2020

working the merge issues now

@spyhunter99
Copy link
Copy Markdown
Collaborator

spyhunter99 commented Jul 22, 2020

so i did a test merge, the sample 'custom my location overlay' was waaaaay off....but so is master. I'm not sure what happened to it. Looks like the icon was resized and/or scaled and the scaling did not account for screen resolution or something

@spyhunter99
Copy link
Copy Markdown
Collaborator

spyhunter99 commented Jul 22, 2020

looks like the way off was introduced in 6.1.4

@spyhunter99 spyhunter99 modified the milestones: v6.1.7, 6.1.8 Jul 22, 2020
@monsieurtanuki
Copy link
Copy Markdown
Collaborator Author

monsieurtanuki commented Jul 22, 2020

@spyhunter99 Actually it was just some refactoring when I was idle, not a fix.

Perhaps a sensitive way to handle this would be to split the code, creating a class that "just" displays the circle and the icon for a given Location and screen density - beyond the refactoring step, this is where the current issue probably is. And then MyLocationNewOverlay as a IMyLocationConsumer that calls that new class display method. In short: the GPS is not reliable on my smartphone and I cannot test it!

@spyhunter99 spyhunter99 removed this from the 6.1.8 milestone Jul 26, 2020
@monsieurtanuki monsieurtanuki merged commit ef72e34 into master Sep 2, 2021
@bemdark bemdark mentioned this pull request Oct 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monsieurtanuki @spyhunter99