Repository navigation
fix(web): recover secret view retry states - #146
Merged
Merged
Conversation
Drop component tests in favor of a follow-up e2e approach, replace staleTime Infinity with enabled + not-found guards, and prevent double-submit on Try Again.
Member
|
Thanks for filing #145 and for the solid fix — the manual-key recovery and retry-via-mutate changes were the right call. I pushed a small follow-up onto this branch after review:
|
dillonstreator
approved these changes
Aug 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm --filter @crypt.fyi/web test(2 files, 14 tests)pnpm --filter @crypt.fyi/web lintpnpm --filter @crypt.fyi/web typecheckpnpm build(5 workspace builds)pnpm typecheck(4 workspace typechecks)pnpm install --frozen-lockfilepnpm peers checkpnpm changeset statusgit diff --checkNot run locally: server integration tests because Docker/Redis was unavailable; no server files changed. Full-repository formatting and lint on this Windows checkout report CRLF-only failures in untouched files; the web package and every changed file pass their applicable checks.
Closes #145
AI assistance
OpenAI Codex assisted with implementation and testing. Claude Code provided an independent sealed review that led to expanded coverage, and Google Antigravity performed the final independent sealed review of the current head. The submitter reviewed, reproduced, verified, and owns the changes.