Skip to content

Wrong key and rate-limit retries can leave the view flow unrecoverable #145

Closed

Description

@snowyukitty

Problem

The post-merge key-entry flow has two retry states that cannot recover:

  1. Open a key-free secret URL and submit an incorrect decryption key.
    • Expected: the key form returns with an error so the recipient can correct a typo.
    • Actual: the page shows "This link is invalid" and only offers "Create New Secret."
  2. Open a combined URL, trigger a 429 while reading, then select "Try Again."
    • Expected: the read is retried or the flow returns to the "View Secret" confirmation.
    • Actual: the main content becomes blank.

Cause

The manual-key error branch clears keySource but leaves the mutation error, and the invalid-link guard runs before the credential form. The 429 retry resets the mutation while retaining the confirmed state, leaving no data and no renderable retry state.

Proposed fix

Restore the credential form after a failed manual key, make retry re-enter a valid read state, and add component regression tests for both transitions.

AI assistance: OpenAI Codex assisted with reproduction and issue drafting. The report was verified against the current application flow by the submitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions