fix: correctly return unset for consistency (#732)

aeneasr · web-flow · commit 4126131c916e · 2023-10-11T16:36:29.000+02:00
diff --git a/crdbx/staleness.go b/crdbx/staleness.go
@@ -66,7 +66,7 @@ func ConsistencyLevelFromString(in string) ConsistencyLevel {
 	case string(ConsistencyLevelEventual):
 		return ConsistencyLevelEventual
 	case string(ConsistencyLevelUnset):
-		return ConsistencyLevelStrong
+		return ConsistencyLevelUnset
 	}
 	return ConsistencyLevelStrong
 }
diff --git a/crdbx/staleness_test.go b/crdbx/staleness_test.go
@@ -14,7 +14,7 @@ import (
 )
 
 func TestConsistencyLevelFromString(t *testing.T) {
-	assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString(""))
+	assert.Equal(t, ConsistencyLevelUnset, ConsistencyLevelFromString(""))
 	assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString("strong"))
 	assert.Equal(t, ConsistencyLevelEventual, ConsistencyLevelFromString("eventual"))
 	assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString("lol"))
@@ -24,6 +24,7 @@ func TestConsistencyLevelFromRequest(t *testing.T) {
 	assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=strong")}))
 	assert.Equal(t, ConsistencyLevelEventual, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=eventual")}))
 	assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=asdf")}))
+	assert.Equal(t, ConsistencyLevelUnset, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency")}))
 
 }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func ConsistencyLevelFromString(in string) ConsistencyLevel {`
`66`	`66`	`case string(ConsistencyLevelEventual):`
`67`	`67`	`return ConsistencyLevelEventual`
`68`	`68`	`case string(ConsistencyLevelUnset):`
`69`		`- return ConsistencyLevelStrong`
	`69`	`+ return ConsistencyLevelUnset`
`70`	`70`	`}`
`71`	`71`	`return ConsistencyLevelStrong`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ import (`
`14`	`14`	`)`
`15`	`15`
`16`	`16`	`func TestConsistencyLevelFromString(t *testing.T) {`
`17`		`- assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString(""))`
	`17`	`+ assert.Equal(t, ConsistencyLevelUnset, ConsistencyLevelFromString(""))`
`18`	`18`	`assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString("strong"))`
`19`	`19`	`assert.Equal(t, ConsistencyLevelEventual, ConsistencyLevelFromString("eventual"))`
`20`	`20`	`assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromString("lol"))`
`@@ -24,6 +24,7 @@ func TestConsistencyLevelFromRequest(t *testing.T) {`
`24`	`24`	`assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=strong")}))`
`25`	`25`	`assert.Equal(t, ConsistencyLevelEventual, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=eventual")}))`
`26`	`26`	`assert.Equal(t, ConsistencyLevelStrong, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency=asdf")}))`
	`27`	`+ assert.Equal(t, ConsistencyLevelUnset, ConsistencyLevelFromRequest(&http.Request{URL: urlx.ParseOrPanic("/?consistency")}))`
`27`	`28`
`28`	`29`	`}`
`29`	`30`