Merged
Conversation
zepatrik
commented
Aug 8, 2023
Member
You can start the server and make an HTTP request to an endpoint with |
aeneasr
reviewed
Aug 10, 2023
aeneasr
previously approved these changes
Aug 10, 2023
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
LGTM please verify that empty domains != allow all domains.
Member
Author
|
Manual testing confirmed it works. |
Member
Author
|
Tests are failing because of ory/x bump which does not work on mysql thanks to gobuffalo/pop#829 |
Codecov Report
@@ Coverage Diff @@
## master #3423 +/- ##
==========================================
- Coverage 78.02% 78.01% -0.01%
==========================================
Files 327 327
Lines 21402 21406 +4
==========================================
+ Hits 16698 16699 +1
- Misses 3466 3468 +2
- Partials 1238 1239 +1
|
aeneasr
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs ory/x#713
With this PR, CORS allowed-origins will be hot-reloadable. Is there a good place to put an integration test? Only e2e I guess?