feat: graceful refresh token rotation#3860
Conversation
aeneasr
force-pushed
the
refresh-token-expiration-window-2
branch
3 times, most recently
from
e8ebba8 to
fea96ff
Compare
aeneasr
changed the title
aeneasr
force-pushed
the
refresh-token-expiration-window-2
branch
from
db1b1fd to
9d66008
Compare
This patch adds a configuration flag which enables graceful refresh token rotation. Previously, refresh tokens could only be used once. On reuse, all tokens of that chain would be revoked. This is particularly challenging in environments, where it's difficult to make guarantees on synchronization. This could lead to refresh tokens being sent twice due to some parallel execution. To resolve this, refresh tokens can now be graceful by changing `oauth2.grant.refresh_token.grace_period=10s` (example value). During this time, a refresh token can be used multiple times to generate new refresh, ID, and access tokens. All tokens will correctly be invalidated, when the refresh token is re-used after the grace period expires, or when the delete consent endpoint is used. Closes #1831 #3770
aeneasr
force-pushed
the
refresh-token-expiration-window-2
branch
from
9d66008 to
3d7414e
Compare
|
From the original PR:
|
I think we test this here: https://github.com/ory/hydra/pull/3860/files#diff-6d883efffdabd9715dc9872121018df30a5843c81e25dc6c4af2c3edc13fb21cR442 |
Co-authored-by: Patrik <[email protected]>
Co-authored-by: Patrik <[email protected]>
Co-authored-by: Patrik <[email protected]>
|
@zepatrik can you please approve if you're fine with the state as it is? |
|
I have added a test case that revokes the consent session and checks that all tokens are correctly invalidated. Tests pass :) |
3 participants
Related issue(s)
Closes #3770
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments