Skip to content

chore: compile a static binary in Docker#3826

Merged
alnr merged 2 commits intomasterfrom
alnr/static
Aug 30, 2024
Merged

chore: compile a static binary in Docker#3826
alnr merged 2 commits intomasterfrom
alnr/static

Conversation

@alnr
Copy link
Copy Markdown
Contributor

@alnr alnr commented Aug 29, 2024

Move to distroless/static-debian12 from distroless/base-nossl-debian12 to get fewer CVE alerts

Uses the technique described in https://www.arp242.net/static-go.html

@alnr alnr self-assigned this Aug 29, 2024
@alnr alnr requested review from aeneasr and hperl as code owners August 29, 2024 14:08
@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 29, 2024

Does SQLite with JSON still work correctly if this patch is applied?

@alnr
Copy link
Copy Markdown
Contributor Author

alnr commented Aug 29, 2024

Does SQLite with JSON still work correctly if this patch is applied?

I believe so. The json1 tag may in fact no longer be necessary. See https://www.sqlite.org/compile.html (SQLITE_ENABLE_JSON1).

Wanted to get a CI run through first of all, and see if I can find any regressions.

This is no longer necessary since SQLite 3.38, and was in fact removed completely in go-sqlite v1.14.13
@alnr
Copy link
Copy Markdown
Contributor Author

alnr commented Aug 29, 2024

mattn/go-sqlite3#1044

This commit deleted all build tags associated with JSON. The first released version with that change is 1.14.13. We should be good.

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 29, 2024

Oh, that's great!

@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Aug 29, 2024

The best way to test for regression is to probably execute the quickstart using the updated image

@alnr
Copy link
Copy Markdown
Contributor Author

alnr commented Aug 30, 2024

Image works! Tested a couple of things, including QuickStart

@alnr alnr merged commit 93edc9a into master Aug 30, 2024
@alnr alnr deleted the alnr/static branch August 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants