feat: add id parameter to create oauth2-client cli#3725
Merged
aeneasr merged 2 commits intoory:masterfrom Apr 26, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
=======================================
Coverage 76.29% 76.30%
=======================================
Files 134 134
Lines 10214 10217 +3
=======================================
+ Hits 7793 7796 +3
Misses 1904 1904
Partials 517 517 ☔ View full report in Codecov by Sentry. |
inigohu
force-pushed
the
feature/cli-add-id-create-oauth2-client-param
branch
from
cf75dcc to
2f708dd
Compare
aeneasr
requested changes
Mar 5, 2024
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)
cmd/cmd_update_client.go
Outdated
| } | ||
|
|
||
| id := args[0] | ||
| if f := cmd.Flag(flagClientId); f.Changed { |
Member
There was a problem hiding this comment.
Can you please only add this flag to create_client?
Contributor
Author
There was a problem hiding this comment.
The cmd_update_client.go uses the same flags as cmd_create_client.go. Both use the flags defined in cmd_helper_client.go.
inigohu
force-pushed
the
feature/cli-add-id-create-oauth2-client-param
branch
from
2f708dd to
f3b7ed0
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#3724
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments