feat: add access token strategy parameter to cli#3718
Merged
aeneasr merged 1 commit intoory:masterfrom Mar 5, 2024
Merged
Conversation
5 tasks
jagobagascon
force-pushed
the
feature/cli-add-access-token-strategy-param
branch
from
790e4dc to
60a2588
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3718 +/- ##
=======================================
Coverage 76.22% 76.23%
=======================================
Files 134 134
Lines 10210 10212 +2
=======================================
+ Hits 7783 7785 +2
Misses 1910 1910
Partials 517 517 ☔ View full report in Codecov by Sentry. |
bateller
approved these changes
Feb 22, 2024
aeneasr
requested changes
Mar 5, 2024
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Can you please add this to update client as well?
Contributor
Author
|
Aren't create and update methods sharing their flags via |
jagobagascon
force-pushed
the
feature/cli-add-access-token-strategy-param
branch
from
440b725 to
0e085e1
Compare
Member
|
You're right! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows setting the access token strategy using the Hydra CLI:
--access-token-strategy jwt.Related issue(s)
#3717
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.