feat: propagate logout to identity provider#3596
Merged
Conversation
hperl
commented
Aug 4, 2023
hperl
commented
Aug 4, 2023
hperl
force-pushed
the
logout-notify-idp
branch
4 times, most recently
from
017859b to
bf7b3ef
Compare
7 tasks
jonas-jonas
previously approved these changes
Aug 10, 2023
hperl
force-pushed
the
logout-notify-idp
branch
from
2b3718d to
8d35bcd
Compare
alnr
reviewed
Aug 10, 2023
alnr
reviewed
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #3596 +/- ##
==========================================
+ Coverage 76.26% 76.29% +0.03%
==========================================
Files 132 132
Lines 9930 9974 +44
==========================================
+ Hits 7573 7610 +37
- Misses 1840 1845 +5
- Partials 517 519 +2 |
hperl
force-pushed
the
logout-notify-idp
branch
from
8d35bcd to
802e3a3
Compare
This commit improves the integration between Hydra and Kratos when logging out the user. This adds a new configuration key for configuring a Kratos admin URL. Additionally, Kratos can send a session ID when accepting a login request. If a session ID was specified and a Kratos admin URL was configured, Hydra will disable the corresponding Kratos session through the admin API if a frontchannel or backchannel logout was triggered.
hperl
force-pushed
the
logout-notify-idp
branch
from
802e3a3 to
4649f4d
Compare
alnr
approved these changes
Aug 10, 2023
alnr
reviewed
Aug 10, 2023
alnr
previously approved these changes
Aug 11, 2023
aeneasr
requested changes
Aug 14, 2023
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Nice! Few things:
- naming (config, api, db)
- test for migration
- ConfirmLoginSession does not set login session id correctly+
persistence/sql/migrations/20230809122501000001_add_kratos_session_id.up.sql
Outdated
Show resolved
Hide resolved
aeneasr
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user logs out of Hydra, we want to propagate this to a connected Ory Kratos instance so that the user is also logged out there.
Related issue(s)
Part of https://github.com/ory-corp/cloud/issues/5038
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments