Skip to content

fix: double hashing of access token signature#3486

Merged
aeneasr merged 1 commit intomasterfrom
hperl/fix-double-hashing
Apr 11, 2023
Merged

fix: double hashing of access token signature#3486
aeneasr merged 1 commit intomasterfrom
hperl/fix-double-hashing

Conversation

@hperl
Copy link
Copy Markdown
Contributor

@hperl hperl commented Apr 11, 2023

Related issue(s)

Fixes #3485

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner April 11, 2023 08:40
@hperl hperl requested a review from alnr April 11, 2023 08:40
@hperl hperl self-assigned this Apr 11, 2023
@hperl hperl added the bug Something is not working. label Apr 11, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2023

Codecov Report

Merging #3486 (ba90123) into master (0448284) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head ba90123 differs from pull request most recent head 02f4fe1. Consider uploading reports for the commit 02f4fe1 to get more accurate results

@@            Coverage Diff             @@
##           master    #3486      +/-   ##
==========================================
- Coverage   76.84%   76.82%   -0.03%     
==========================================
  Files         124      124              
  Lines        9174     9173       -1     
==========================================
- Hits         7050     7047       -3     
- Misses       1674     1677       +3     
+ Partials      450      449       -1
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 81.43% <ø> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 8720b25 into master Apr 11, 2023
@aeneasr aeneasr deleted the hperl/fix-double-hashing branch April 11, 2023 09:16
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
@hperl @harnash
fix: double-hashed access token signatures (ory#3486)
717be94 
Fixes ory#3485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeneasr aeneasr aeneasr approved these changes

@alnr alnr alnr approved these changes

Assignees

@hperl hperl

Labels

bug Something is not working.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Access token signature lookup bug

3 participants

@hperl @aeneasr @alnr