feat: extend session lifespan on session refresh (skip=true)#3464
Merged
aeneasr merged 6 commits intoory:masterfrom Mar 16, 2023
sgal:refresh-remember-on-use
Merged
feat: extend session lifespan on session refresh (skip=true)#3464aeneasr merged 6 commits intoory:masterfrom sgal:refresh-remember-on-use
aeneasr merged 6 commits intoory:masterfrom
sgal:refresh-remember-on-use
Conversation
sgal
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3464 +/- ##
==========================================
+ Coverage 73.91% 76.83% +2.91%
==========================================
Files 123 123
Lines 9553 9125 -428
==========================================
- Hits 7061 7011 -50
+ Misses 2040 1666 -374
+ Partials 452 448 -4
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aeneasr
requested changes
Mar 13, 2023
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Please add a migration test file for the new migration :)
persistence/sql/migrations/20220914000001000000_support_refresh_remember_for.sqlite.up.sql
Show resolved
Hide resolved
The access token type (`jwt` or `opaque`) can now be set in the client configuration. The value set here will overwrite the global value for all flows concerning that client.
Contributor
Author
|
@aeneasr Added migration test and fixed comments, please have a look! |
aeneasr
approved these changes
Mar 16, 2023
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Great job, thank you very much!
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
It is now possible to extend session lifespans when accepting login challenges. Closes ory#1690 Closes ory#1557 Closes ory#2246 Closes ory#2848 Co-authored-by: Mart Aarma <[email protected]> Co-authored-by: Henning Perl <[email protected]> Co-authored-by: ory-bot <[email protected]>
alarkvell
pushed a commit
to e-gov/GovSSO-Session
that referenced
this pull request
Nov 28, 2023
alarkvell
pushed a commit
to e-gov/GovSSO-Session
that referenced
this pull request
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Picking up work done in #2848 to speed up the delivery, since the author is on vacation.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments