hperl/per-client-token-types by hperl · Pull Request #3446 · ory/hydra

hperl · 2023-02-22T09:37:48Z

Related issue(s)

Checklist

I have read the contributing guidelines.
I have referenced an issue containing the design document if my change
introduces a new feature.
I am following the
contributing code guidelines.
I have read the security policy.
I confirm that this pull request does not address a security
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
I have added tests that prove my fix is effective or that my feature
works.
I have added or changed the documentation.

Further Comments

codecov · 2023-02-22T10:03:16Z

Codecov Report

Merging #3446 (602b423) into master (375bd5a) will decrease coverage by 0.01%.
The diff coverage is 84.28%.

❗ Current head 602b423 differs from pull request most recent head 2ec7a94. Consider uploading reports for the commit 2ec7a94 to get more accurate results

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.01%     
==========================================
  Files         123      123              
  Lines        9073     9105      +32     
==========================================
+ Hits         6972     6996      +24     
- Misses       1659     1664       +5     
- Partials      442      445       +3

Impacted Files	Coverage Δ
client/validator.go	`69.82% <50.00%> (-3.33%)`	⬇️
driver/config/provider.go	`81.85% <55.55%> (-0.71%)`	⬇️
client/client.go	`76.41% <85.71%> (+0.65%)`	⬆️
fositex/token_strategy.go	`100.00% <100.00%> (ø)`
oauth2/fosite_store_helpers.go	`100.00% <100.00%> (ø)`
oauth2/handler.go	`66.50% <100.00%> (ø)`
persistence/sql/persister_oauth2.go	`82.26% <100.00%> (-0.63%)`	⬇️
jwk/handler.go	`67.77% <0.00%> (+3.33%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aeneasr · 2023-02-23T09:25:16Z

For the tests, please check that jwt->jwt, jwt->opaque, opaque->jwt, opaque->opaque and flows:

client credentials: issue token, validate token, invalidate token
auth code: issue token, validate token, refresh token, validate token, invalidate token, call userinfo endpoint
jwt-bearer flow: does it issue the token in the correct format?

driver/config/provider.go

jwk/handler_test.go

oauth2/fosite_store_helpers.go

persistence/sql/persister_oauth2.go

cypress/integration/oauth2/authorize_code.js

aeneasr

Please make this not available in OIDC dynamic client registration.

aeneasr

Great job, looks good!

aeneasr · 2023-03-02T13:03:58Z

merge conflicts 🙄

The access token type (`jwt` or `opaque`) can now be set in the client configuration. The value set here will overwrite the global value for all flows concerning that client.

hperl · 2023-03-02T15:08:37Z

@aeneasr all resolved now :)

The access token type (`jwt` or `opaque`) can now be set in the client configuration. The value set here will overwrite the global value for all flows concerning that client.

hperl requested a review from aeneasr February 22, 2023 09:37

hperl self-assigned this Feb 22, 2023

hperl force-pushed the hperl/per-client-token-types branch 3 times, most recently from d0cae03 to 1130b7f Compare February 27, 2023 16:05