Skip to content

fix: enable datadog tracer#3431

Merged
aeneasr merged 4 commits intoory:masterfrom
sawadashota:config_otel
Feb 6, 2023
Merged

fix: enable datadog tracer#3431
aeneasr merged 4 commits intoory:masterfrom
sawadashota:config_otel

Conversation

@sawadashota
Copy link
Copy Markdown
Contributor

@sawadashota sawadashota commented Feb 5, 2023

Load OpenTelemetry configuration to set up datadog tracer.

Related issue(s)

none

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@sawadashota
fix: Load otlp configuration
d92fb11 
Signed-off-by: sawadashota <[email protected]>
@sawadashota sawadashota requested a review from aeneasr as a code owner February 5, 2023 13:21
sawadashota
sawadashota commented Feb 5, 2023
View reviewed changes
.docker/Dockerfile-build

COPY go.mod go.sum ./
COPY internal/httpclient/go.* ./internal/httpclient
COPY internal/httpclient/go.* ./internal/httpclient/
Copy link
Copy Markdown
Contributor Author

@sawadashota sawadashota Feb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a trailing slash, it will fail.

Step 6/21 : COPY internal/httpclient/go.* ./internal/httpclient
When using COPY with more than one source file, the destination must be a directory and end with a /
make: *** [docker] Error 1

@sawadashota sawadashota changed the title fix: Enable datadog tracer fix: enable datadog tracer Feb 5, 2023
@aeneasr aeneasr requested a review from alnr February 5, 2023 14:30
@aeneasr
Copy link
Copy Markdown
Member

aeneasr commented Feb 5, 2023

Seems like tests are failing, can you PTAL? :)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #3431 (ce2f444) into master (5585539) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
+ Coverage   76.47%   76.74%   +0.26%     
==========================================
  Files         123      123              
  Lines       10535     9022    -1513     
==========================================
- Hits         8057     6924    -1133     
+ Misses       1990     1657     -333     
+ Partials      488      441      -47
Impacted Files Coverage Δ
driver/config/provider.go 82.55% <0.00%> (-5.70%) ⬇️
consent/handler.go 66.01% <0.00%> (-4.99%) ⬇️
persistence/sql/persister_consent.go 87.41% <0.00%> (-2.34%) ⬇️
driver/registry_base.go 85.93% <0.00%> (-1.76%) ⬇️
x/clean_sql.go 91.11% <0.00%> (-1.62%) ⬇️
consent/manager.go 100.00% <0.00%> (ø)
consent/strategy_default.go 69.59% <0.00%> (+0.59%) ⬆️
fositex/config.go 86.11% <0.00%> (+2.64%) ⬆️
oauth2/handler.go 66.50% <0.00%> (+2.82%) ⬆️
persistence/sql/persister_oauth2.go 82.12% <0.00%> (+5.86%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sawadashota
Copy link
Copy Markdown
Contributor Author

sawadashota commented Feb 6, 2023

@aeneasr I'm sorry, but I've fixed it!

aeneasr
aeneasr reviewed Feb 6, 2023
View reviewed changes
alnr
alnr approved these changes Feb 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawadashota

@aeneasr aeneasr merged commit 3ea014f into ory:master Feb 6, 2023
@sawadashota sawadashota deleted the config_otel branch February 6, 2023 13:38
This was referenced Feb 7, 2023
Closed
Merged
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
@sawadashota @harnash
feat: support datadog tracing (ory#3431)
fd23e9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aeneasr aeneasr aeneasr left review comments

@alnr alnr alnr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sawadashota @aeneasr @alnr