fix: fix hydra_client pk change mysql down migration#2791
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v2.x #2791 +/- ##
=======================================
Coverage ? 52.85%
=======================================
Files ? 236
Lines ? 14185
Branches ? 0
=======================================
Hits ? 7498
Misses ? 6054
Partials ? 633 Continue to review full report at Codecov.
|
aeneasr
approved these changes
Oct 13, 2021
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Feb 7, 2022
grantzvolsky
added a commit
to grantzvolsky/hydra
that referenced
this pull request
Mar 8, 2022
grantzvolsky
added a commit
that referenced
this pull request
May 19, 2022
aeneasr
pushed a commit
that referenced
this pull request
Jun 27, 2022
grantzvolsky
added a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 18, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 5, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#2790
@aeneasr
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
I tested the change manually by writing the output of
show create table hydra_client;before the up migration (a), after the up migration (b), and after the down migration (c), and making sure that a == c. We might want to add a test that does this automatically for all down migrations, or at least a convenience script that runs this procedure for a given migration.