fix: skip malformed origins

zepatrik · zepatrik · commit 12cc543cbfcc · 2023-06-12T16:31:31.000+02:00
diff --git a/x/oauth2cors/cors.go b/x/oauth2cors/cors.go
@@ -49,9 +49,8 @@ func Middleware(
 				}
 				g, err := glob.Compile(strings.ToLower(o), '.')
 				if err != nil {
-					reg.Logger().WithError(err).WithField("pattern", o).Error("Unable to parse CORS origin")
-					h.ServeHTTP(w, r)
-					return
+					reg.Logger().WithError(err).WithField("pattern", o).Error("Unable to parse CORS origin, ignoring it")
+					continue
 				}
 
 				patterns = append(patterns, g)

Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,8 @@ func Middleware(`
`49`	`49`	`}`
`50`	`50`	`g, err := glob.Compile(strings.ToLower(o), '.')`
`51`	`51`	`if err != nil {`
`52`		`- reg.Logger().WithError(err).WithField("pattern", o).Error("Unable to parse CORS origin")`
`53`		`- h.ServeHTTP(w, r)`
`54`		`- return`
	`52`	`+ reg.Logger().WithError(err).WithField("pattern", o).Error("Unable to parse CORS origin, ignoring it")`
	`53`	`+ continue`
`55`	`54`	`}`
`56`	`55`
`57`	`56`	`patterns = append(patterns, g)`