feat: update webhook documentation with more grant types#1241
Merged
hperl merged 4 commits intoory:masterfrom Apr 25, 2023
Merged
feat: update webhook documentation with more grant types#1241hperl merged 4 commits intoory:masterfrom
hperl merged 4 commits intoory:masterfrom
Conversation
sgal
requested review from
aeneasr,
fbolton,
piotrmsc,
tomekpapiernik,
vinckr and
zepatrik
as code owners
7 tasks
sgal
force-pushed
the
update-hook-docs-grant-types-payload
branch
from
0911fa3 to
9421183
Compare
Contributor
Author
tomekpapiernik
suggested changes
Feb 27, 2023
vinckr
changed the title
sgal
force-pushed
the
update-hook-docs-grant-types-payload
branch
2 times, most recently
from
d937177 to
f415823
Compare
Contributor
Author
|
@tomekpapiernik Thanks for the review. I reverted the document ID and the sidebar changes and fixed the writing. Please have a look. |
Contributor
|
Thanks for updating your PR @sgal ! I took the liberty of editing this a bit more. Most important change - I updated the Ory CLI to use --add instead of --replace, as the keys you want to work with aren't present in the oauth2 config from the get-go - they must be added. The --replace command doesn't do that. I'll approve this PR and it can be merged along with the code PR you opened. |
tomekpapiernik
previously approved these changes
Mar 6, 2023
Contributor
Author
|
@tomekpapiernik Thanks a lot for the review and fixes 👏 |
sgal
force-pushed
the
update-hook-docs-grant-types-payload
branch
from
f844010 to
00d3bb4
Compare
sgal
force-pushed
the
update-hook-docs-grant-types-payload
branch
from
00d3bb4 to
45411f6
Compare
sgal
force-pushed
the
update-hook-docs-grant-types-payload
branch
from
45411f6 to
a025d2a
Compare
Contributor
Author
|
@aeneasr The PR in Hydra is already merged, shall we merge this as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Documentation update for ory/hydra#3427.
This change adds guides for adding/updating custom token claims via webhook feature for the following set of grant types:
authorization_codeclient_credentialsrefresh_tokenurn:ietf:params:oauth:client-assertion-type:jwt-bearerChecklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments