feat: handle legacy config with helpful advice (#365)

zepatrik · web-flow · commit 822928949844 · 2024-07-16T09:13:21.000+02:00
diff --git a/cmd/cloudx/client/config.go b/cmd/cloudx/client/config.go
@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"io"
 	"io/fs"
 	"os"
 	"path/filepath"
@@ -88,6 +89,24 @@ func (h *CommandHelper) getConfig() (*Config, error) {
 		if err != nil {
 			return nil, err
 		}
+		switch c.Version {
+		case "v0alpha0":
+			if h.isQuiet {
+				return nil, fmt.Errorf("you have to authenticate the Ory CLI now differently, plese see ory auth for details")
+			}
+
+			_, _ = fmt.Fprintln(h.VerboseErrWriter, "Thanks for upgrading! You will now be prompted to log in to the Ory CLI through the Ory Console.")
+			_, _ = fmt.Fprintln(h.VerboseErrWriter, "Press enter to continue...")
+			_, err := h.Stdin.ReadString('\n')
+			if err != nil && err != io.EOF {
+				return nil, fmt.Errorf("unable to read from stdin: %w", err)
+			}
+			fallthrough
+		default:
+			return nil, ErrNoConfig
+		case ConfigVersion:
+			// pass
+		}
 		h.config = c
 	}
 	return h.config, nil
diff --git a/cmd/cloudx/client/config_test.go b/cmd/cloudx/client/config_test.go
@@ -0,0 +1,40 @@
+// Copyright © 2024 Ory Corp
+// SPDX-License-Identifier: Apache-2.0
+
+package client_test
+
+import (
+	"bytes"
+	"context"
+	"os"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"github.com/ory/cli/cmd/cloudx/client"
+	"github.com/ory/cli/cmd/cloudx/testhelpers"
+)
+
+func TestLegacyConfigHandling(t *testing.T) {
+	ctx := context.Background()
+	legacyConfigFile := testhelpers.NewConfigFile(t)
+	require.NoError(t, os.WriteFile(legacyConfigFile, []byte(`{"version": "v0alpha0"}`), 0600))
+
+	out := bytes.Buffer{}
+	h, err := client.NewCommandHelper(
+		ctx,
+		client.WithConfigLocation(legacyConfigFile),
+		client.WithOpenBrowserHook(func(string) error {
+			return testhelpers.ErrAuthFlowTriggered
+		}),
+		client.WithVerboseErrWriter(&out),
+		client.WithStdin(strings.NewReader("\n")),
+	)
+	require.NoError(t, err)
+
+	_, err = h.GetAuthenticatedConfig(ctx)
+	assert.ErrorIs(t, err, testhelpers.ErrAuthFlowTriggered)
+	assert.Contains(t, out.String(), "Thanks for upgrading!")
+}
