fix(zod): fixed an issue where oneOf was missing additional properties
#2675
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where oneOf schemas were not properly handling additional properties. The change updates the condition for merging additional properties to explicitly check for the presence of allOf, oneOf, or anyOf schemas before processing, rather than just checking if properties exist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Handle allOf/oneOf/anyOf with additional properties | ||
| if (schema.properties && Object.keys(schema.properties).length > 0) { | ||
| // Handle allOf/oneOf/anyOf with additional properties - merge additional properties into the schema | ||
| if ((schema.allOf || schema.oneOf || schema.anyOf) && schema.properties) { |
There was a problem hiding this comment.
The condition uses a logical OR to check if any of these properties exist, which evaluates to true even if the property is an empty array. This could lead to unnecessary processing when the array is empty. Consider checking both existence and non-emptiness: ((schema.allOf?.length || schema.oneOf?.length || schema.anyOf?.length) && schema.properties)
2 participants
Follow-up to #2672
I had the same problem with
oneOf, so I fixed it.