feat(fetch): make output.schemas.type exclusive and remove override.fetch.useSchemaResponse
#2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the schema type configuration by making output.schemas.type accept only a single value ('typescript' | 'zod') instead of an array, and removes the override.fetch.useZodSchemaResponse option. When type: 'zod' is specified, all imports now automatically come from .zod.ts files.
Key Changes:
- Changed
output.schemas.typefrom accepting an array to accepting a single value - Removed the
override.fetch.useZodSchemaResponseconfiguration option - Simplified import generation logic in the fetch client to automatically use zod schema imports when
type: 'zod'is configured
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/configs/fetch.config.ts | Updated test configurations to use single schema type values and removed useZodSchemaResponse option |
| tests/configs/default.config.ts | Removed test configuration that used multiple schema types |
| packages/orval/src/write-specs.ts | Simplified schema type handling to work with single values instead of arrays |
| packages/orval/src/utils/options.ts | Updated normalization logic to handle single schema type values and removed useZodSchemaResponse option handling |
| packages/orval/src/client.ts | Added output parameter to generatorClient function call |
| packages/fetch/src/index.ts | Refactored import generation to automatically detect and use zod schemas based on output configuration |
| packages/core/src/types.ts | Updated type definitions to reflect single schema type values and removed useZodSchemaResponse from fetch options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
melloware
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2598
Summary
Changed
output.schemas.typeto accept only single values ('typescript'|'zod') and removed theuseZodSchemaResponseoption.Changes
Configuration
{ output: { schemas: { - type: ['typescript', 'zod'] + type: 'zod' }, - override: { - fetch: { - useZodSchemaResponse: true - } - } } }Generated Code
When
type: 'zod'is specified, all types are now imported from.zod.tsfiles.