Skip to content

#2616 fix(fetch): Fix client generation when params contain dates but exploded params do not. #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soartec-lab merged 1 commit into from
Dec 3, 2025
Merged

#2616 fix(fetch): Fix client generation when params contain dates but exploded params do not. #2617

soartec-lab merged 1 commit into from
Dec 3, 2025

Conversation

@jlillywhite
Copy link
Contributor

@jlillywhite jlillywhite commented Dec 2, 2025 •
edited by melloware
Loading

Fix #2616.

  • Adds a separate check to see if the explodedParams contains date-time params.
  • Also fixes a typo in the name of the normalParamsImplementation

@melloware melloware requested a review from soartec-lab December 2, 2025 17:47
@melloware melloware added the fetch Fetch client related issue label Dec 2, 2025
@melloware
Copy link
Collaborator

melloware commented Dec 2, 2025

@soartec-lab one for you to review

soartec-lab
soartec-lab approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

@soartec-lab soartec-lab added the bug Something isn't working label Dec 3, 2025
@soartec-lab soartec-lab added this to the 7.17.0 milestone Dec 3, 2025
@soartec-lab soartec-lab changed the title #2616 fix(fetch-client): Fix client generation when params contain dates but exploded params do not. #2616 fix(fetch): Fix client generation when params contain dates but exploded params do not. Dec 3, 2025
@soartec-lab soartec-lab merged commit 88be161 into orval-labs:master Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soartec-lab soartec-lab soartec-lab approved these changes

Assignees

@soartec-lab soartec-lab

Labels

bug Something isn't working fetch Fetch client related issue

Projects

None yet

Milestone

7.17.0

Development

Successfully merging this pull request may close these issues.

Fetch client generates invalid typescript when params contain dates, but exploded params don't

4 participants

@jlillywhite @melloware @soartec-lab @jlillywhite-mc