fix(core): topologically sort schema declarations by dependencies #2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
force-pushed
the
fix/enum-declaration-order
branch
from
c00bf22 to
b16898d
Compare
Collaborator
|
you might have to run |
melloware
force-pushed
the
fix/enum-declaration-order
branch
from
b16898d to
8412dcc
Compare
Contributor
Author
|
Ah, thanks! It said unchanged previously, but that is nonsense. Had to clean caches to get it updated. |
Collaborator
|
ok now |
Schemas/enums were output in alphabetical order, causing TS errors
when a combined enum spread referenced another declared later:
export const Combined = { ...BlankEnum } // error: used before declaration
export const BlankEnum = { '': '' }
Track dependencies through resolvers and sort before output.
Fixes orval-labs#1511
melloware
force-pushed
the
fix/enum-declaration-order
branch
from
42746e9 to
2e0bc10
Compare
melloware
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1511
I ran into this when using orval with a Django REST Framework OpenAPI spec. The generated TypeScript wouldn't compile because enums were declared in the wrong order:
The issue is that schemas get output in alphabetical order, but combined enums using spread syntax need their dependencies declared first.
I added dependency tracking through the resolvers and a topological sort before output. Added a test that reproduces the original issue.