Skip to content

fix(query): include path params info query key when useOperationIdAsQueryKey enabled #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melloware merged 1 commit into from
Dec 1, 2025
Merged

fix(query): include path params info query key when useOperationIdAsQueryKey enabled #2595

melloware merged 1 commit into from
Dec 1, 2025

Conversation

@Armanio
Copy link
Contributor

@Armanio Armanio commented Nov 28, 2025 •
edited by melloware
Loading

Fix #2505

Explanation:

  • drop hardcoded query Params insertion
  • when useOperationIdAsQueryKey=true query param use all parameters
  • when useOperationIdAsQueryKey=false only query params (because path params included in path)
  • all params sorted by required first

Below are screenshots with diffs:
Снимок экрана от 2025-11-28 22-24-17

Снимок экрана от 2025-11-28 22-24-06 Снимок экрана от 2025-11-28 22-23-39

melloware
melloware requested changes Nov 29, 2025
View reviewed changes
@melloware melloware merged commit 0269002 into orval-labs:master Dec 1, 2025
2 checks passed
@Armanio Armanio deleted the operation_id branch December 1, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melloware melloware melloware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Path params not included in query key when useOperationIdAsQueryKey is true

2 participants

@Armanio @melloware