fix(zod): handle falsy default values in schema generation #2501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle falsy default values in Zod schema generation
Problem
When a schema has
default: false(or other falsy values like0,'', ornull), the generated Zod schema incorrectly omits the.default()method and uses.optional()instead. This occurs because the conditionif (!required && schema.default)treats falsy values as falsy in JavaScript.Example from issue #2222:
Before:
Expected:
Solution
Changed the condition from
schema.defaulttoschema.default !== undefinedto properly detect when a default value is set, regardless of whether it's a falsy value.This ensures that all default values, including falsy ones, are properly applied to the Zod schema.