refactor: improve code quality in ASTChain and OgnlContext#502
Merged
lukaszlenart merged 1 commit intomainfrom Nov 29, 2025
Merged
refactor: improve code quality in ASTChain and OgnlContext#502lukaszlenart merged 1 commit intomainfrom
lukaszlenart merged 1 commit intomainfrom
Conversation
Address multiple SonarCloud code quality issues: - Add missing @OverRide annotations (java:S1161) - Use pattern matching for instanceof (java:S6201) - Reduce cognitive complexity by simplifying nested conditions (java:S3776) - Extract string literals "_currentChain" and "_lastChild" as constants (java:S1192) - Improve exception handling by catching Exception instead of Throwable - Improve code readability with isEmpty() and better variable naming 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
lukaszlenart
deleted the
refactor/sonarcloud-code-quality-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address multiple SonarCloud code quality issues in ASTChain and OgnlContext classes:
@Overrideannotations (java:S1161) - Ensures proper method override documentationCURRENT_CHAINandLAST_CHILDconstants in OgnlContextisEmpty()instead of length checks, better variable namingFiles Changed
ognl/src/main/java/ognl/ASTChain.java- Refactored for reduced complexity and modern Java patternsognl/src/main/java/ognl/OgnlContext.java- Added constants for magic stringsTest Plan
🤖 Generated with Claude Code