Fix Issue #472: Revert PR #204 to restore root context preservation in lambda expressions#476
Merged
lukaszlenart merged 1 commit intoognl-3-4-xfrom Nov 1, 2025
Merged
Conversation
…ervation in lambda expressions This commit reverts changes introduced in PR #204 (short-circuit optimization) to fix Issue #472 where lambda expressions in list operations could not access root context properties. Changes: - Removed addDefaultContext() wrapper in Ognl.getValue() that was overwriting context root - Removed short-circuit optimization logic from ASTChain.getValueBody() - Reverted to pre-PR #204 behavior: null property access now throws OgnlException - Updated ChainTest and NullRootTest to expect exceptions instead of null returns - Added comprehensive Issue472CustomMethodAccessorTest with 5 test cases The revert simplifies the codebase and ensures context root preservation throughout nested evaluations, allowing #root references to work correctly in lambda expressions. Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
lukaszlenart
added a commit
that referenced
this pull request
Nov 4, 2025
Port fix from PR #476 (ognl-3-4-x) to main branch with adaptations for backward compatibility. Lambda expressions in list operations (selection, projection) can now access properties from the original context root via #root references. Root cause: Ognl.getValue() called context.withRoot(root) which overwrote the context root during nested evaluations (e.g., when processing list items), making original root properties inaccessible. Solution: Conditionally preserve original root by only calling withRoot() when context has no root, root matches existing root, or context is empty. This maintains backward compatibility while fixing #root access in lambdas. Changes: - Modified Ognl.getValue() to preserve root context during nested evaluations - Added Issue472CustomMethodAccessorTest with 5 comprehensive test cases - All 612 existing tests pass, maintaining backward compatibility - Short-circuit optimization preserved (not removed like in PR #476) Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
added a commit
that referenced
this pull request
Nov 4, 2025
Port fix from PR #476 (ognl-3-4-x) to main branch with adaptations for backward compatibility. Lambda expressions in list operations (selection, projection) can now access properties from the original context root via #root references. Root cause: Ognl.getValue() called context.withRoot(root) which overwrote the context root during nested evaluations (e.g., when processing list items), making original root properties inaccessible. Solution: Conditionally preserve original root by only calling withRoot() when context has no root, root matches existing root, or context is empty. This maintains backward compatibility while fixing #root access in lambdas. Changes: - Modified Ognl.getValue() to preserve root context during nested evaluations - Added Issue472CustomMethodAccessorTest with 5 comprehensive test cases - All 612 existing tests pass, maintaining backward compatibility - Short-circuit optimization preserved (not removed like in PR #476) Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
added a commit
that referenced
this pull request
Nov 7, 2025
Port fix from PR #476 (ognl-3-4-x) to main branch with adaptations for backward compatibility. Lambda expressions in list operations (selection, projection) can now access properties from the original context root via #root references. Root cause: Ognl.getValue() called context.withRoot(root) which overwrote the context root during nested evaluations (e.g., when processing list items), making original root properties inaccessible. Solution: Conditionally preserve original root by only calling withRoot() when context has no root, root matches existing root, or context is empty. This maintains backward compatibility while fixing #root access in lambdas. Changes: - Modified Ognl.getValue() to preserve root context during nested evaluations - Added Issue472CustomMethodAccessorTest with 5 comprehensive test cases - All 612 existing tests pass, maintaining backward compatibility - Short-circuit optimization preserved (not removed like in PR #476) Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
added a commit
that referenced
this pull request
Nov 7, 2025
Port fix from PR #476 (ognl-3-4-x) to main branch with adaptations for backward compatibility. Lambda expressions in list operations (selection, projection) can now access properties from the original context root via #root references. Root cause: Ognl.getValue() called context.withRoot(root) which overwrote the context root during nested evaluations (e.g., when processing list items), making original root properties inaccessible. Solution: Conditionally preserve original root by only calling withRoot() when context has no root, root matches existing root, or context is empty. This maintains backward compatibility while fixing #root access in lambdas. Changes: - Modified Ognl.getValue() to preserve root context during nested evaluations - Added Issue472CustomMethodAccessorTest with 5 comprehensive test cases - All 612 existing tests pass, maintaining backward compatibility - Short-circuit optimization preserved (not removed like in PR #476) Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
lukaszlenart
added a commit
that referenced
this pull request
Nov 7, 2025
Port fix from PR #476 (ognl-3-4-x) to main branch with adaptations for backward compatibility. Lambda expressions in list operations (selection, projection) can now access properties from the original context root via #root references. Root cause: Ognl.getValue() called context.withRoot(root) which overwrote the context root during nested evaluations (e.g., when processing list items), making original root properties inaccessible. Solution: Conditionally preserve original root by only calling withRoot() when context has no root, root matches existing root, or context is empty. This maintains backward compatibility while fixing #root access in lambdas. Changes: - Modified Ognl.getValue() to preserve root context during nested evaluations - Added Issue472CustomMethodAccessorTest with 5 comprehensive test cases - All 612 existing tests pass, maintaining backward compatibility - Short-circuit optimization preserved (not removed like in PR #476) Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #472 where lambda expressions in list operations (selection, projection) cannot access root context properties.
Root Cause: PR #204 introduced
addDefaultContext(root, context)inOgnl.getValue()which overwrote the context root with the current evaluation target (e.g., list items), making original root properties inaccessible via#rootreferences.Solution: Complete revert to pre-PR #204 behavior:
addDefaultContext()wrapper inOgnl.getValue()- context now passed through directly preserving original rootASTChain.getValueBody()- null property access now throwsOgnlExceptionas beforeChainTest,NullRootTest) to expect exceptions instead of null returnsIssue472CustomMethodAccessorTestwith 5 test cases validating root preservationBreaking Change: Accessing properties on null now throws
OgnlExceptioninstead of returning null (reverts to original OGNL behavior).Test Plan
Issue472CustomMethodAccessorTestverifies:#root.property#root.property#rootand#thiswork correctly in lambda expressionsChainTest.shouldShortCircuitAccessingNullChildexpectsOgnlExceptionNullRootTesttests expectOgnlExceptionwith correct error messagesVerified with:
mvn clean test- 947 tests passing, 0 failures, 0 errorsFixes #472
🤖 Generated with Claude Code