Port changes from #449 about root preservation#461
Merged
lukaszlenart merged 2 commits intoognl-3-4-xfrom Oct 26, 2025
Merged
Conversation
Fixes issue where addDefaultContext() unconditionally overwrites the context root, breaking expressions that reference #root during list processing operations (selection, projection, etc.). The fix preserves the original root when: - Context exists with a non-null root - Context has user-defined variables (size() > 0) - A different root is being set (nested evaluation) This allows #root to correctly reference the original context object during list operations while still supporting legitimate context reuse with different roots (when size() == 0). Note: context.size() only counts user-defined variables, not built-in reserved keys like #root, #this, and _traceEvaluations. Fixes #390
Adds test cases covering various scenarios where context root should be preserved during nested evaluations: - List selection with #root references - List projection with #root references - Lambda expressions accessing #root - Context variable access during list processing - Verification that root is not overwritten by list items These tests ensure issue #390 is properly resolved and prevent regression in future changes. Related to #390
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See detailed information in PR #449 which addresses issue #390
Closes #459