When scanning super interfaces in OgnlRuntime#getMethods(Class, bool…#40
Merged
lukaszlenart merged 2 commits intoorphan-oss:masterfrom Nov 16, 2017
Merged
When scanning super interfaces in OgnlRuntime#getMethods(Class, bool…#40lukaszlenart merged 2 commits intoorphan-oss:masterfrom
lukaszlenart merged 2 commits intoorphan-oss:masterfrom
Conversation
…ean)`, only default methods should be collected instead of all declared methods. Also, super interfaces should be searched recursively so that it can handle deeper interface hierarchy.
Collaborator
|
Looks good to me ... give me some time to take another shot (just returned from vacations ;-) |
Contributor
Author
|
Hope you recharged your batteries! =) |
Collaborator
|
@harawata could you resolve that conflict? Or you can target 3.1.x |
harawata
added a commit
to harawata/ognl
that referenced
this pull request
Nov 15, 2017
When scanning super interfaces in `OgnlRuntime#getMethods(Class, boolean)`, only default methods should be collected instead of all declared methods. Also, super interfaces should be searched recursively so that it can handle deeper interface hierarchy.
Contributor
Author
|
@lukaszlenart Done! Thanks! |
lukaszlenart
added a commit
that referenced
this pull request
Nov 16, 2017
Backporting #40 to ognl-3-1-x branch.
Collaborator
|
LGTM 💯 & thank you again :) |
harawata
added a commit
to harawata/ognl
that referenced
this pull request
Jan 8, 2022
The test passes, but there is a message in System.err: Two methods with same method signature but not providing classes assignable? This was originally reported as orphan-oss#35 and temporarily resolved by orphan-oss#40 , but as you can see, this is not an error case in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ean), only default methods should be collected instead of all declared methods. This should fix #35 .
Also, it now searches super interfaces recursively to handle deeper interface hierarchy as follows.
To achieve the recursive search, I extracted some methods. Was it OK ?
I ask because the original code seemed to avoid it intentionally for some reason.
A few not-directly-related things I noticed:
PR fix for issue #29 - Ognl.GetMethods does not return default methods from interfaces implemented by parent class #30 was not applied togetAllMethods(Class, boolean).EDIT:
getAllMethods()usesClass#getMethods()and returns superinterfaces' default methods correctly.If this PR is acceptable, I will send another PR to backport the change to 3.1 (and 3.0 if it's appropriate).