OGNL-102 Improves performance when null was returned#204
Merged
lukaszlenart merged 7 commits intomasterfrom Aug 23, 2023
Merged
OGNL-102 Improves performance when null was returned#204lukaszlenart merged 7 commits intomasterfrom
lukaszlenart merged 7 commits intomasterfrom
Conversation
lukaszlenart
force-pushed
the
OGNL-102-performance
branch
2 times, most recently
from
3c76136 to
e4cd96a
Compare
|
SonarCloud Quality Gate failed. |
lukaszlenart
force-pushed
the
OGNL-102-performance
branch
from
e4cd96a to
f17a24c
Compare
lukaszlenart
force-pushed
the
OGNL-102-performance
branch
from
ad0a395 to
46079a1
Compare
Collaborator
Author
|
SonarCloud Quality Gate failed.
|
lukaszlenart
added a commit
that referenced
this pull request
Nov 1, 2025
…ervation in lambda expressions This commit reverts changes introduced in PR #204 (short-circuit optimization) to fix Issue #472 where lambda expressions in list operations could not access root context properties. Changes: - Removed addDefaultContext() wrapper in Ognl.getValue() that was overwriting context root - Removed short-circuit optimization logic from ASTChain.getValueBody() - Reverted to pre-PR #204 behavior: null property access now throws OgnlException - Updated ChainTest and NullRootTest to expect exceptions instead of null returns - Added comprehensive Issue472CustomMethodAccessorTest with 5 test cases The revert simplifies the codebase and ensures context root preservation throughout nested evaluations, allowing #root references to work correctly in lambda expressions. Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Merged
5 tasks
lukaszlenart
added a commit
that referenced
this pull request
Nov 1, 2025
…ervation in lambda expressions (#476) This commit reverts changes introduced in PR #204 (short-circuit optimization) to fix Issue #472 where lambda expressions in list operations could not access root context properties. Changes: - Removed addDefaultContext() wrapper in Ognl.getValue() that was overwriting context root - Removed short-circuit optimization logic from ASTChain.getValueBody() - Reverted to pre-PR #204 behavior: null property access now throws OgnlException - Updated ChainTest and NullRootTest to expect exceptions instead of null returns - Added comprehensive Issue472CustomMethodAccessorTest with 5 test cases The revert simplifies the codebase and ensures context root preservation throughout nested evaluations, allowing #root references to work correctly in lambda expressions. Fixes #472 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces options to short-circuit chain operations on
nullresult in case if accessing property of the object, eg.obj1.propertywhereobj1is null orobj1.obj2.propertywhereobj2is null.This functionality is enabled by default, use
-Dognl.chain.short-circuit=falseto disable it.Refs #140
Refs OGNL-102