Fix MacOS Static build without FFI#4820
Fix MacOS Static build without FFI#4820eisenhauer wants to merge 4 commits intoornladios:release_211from
Conversation
|
@eisenhauer unfortunately still the same issue with this patch. |
The deal is that this version DILL wont/cant build build on macos without libffi. It can't do dynamic code generation (it's main job) so it falls back to emulation of DCG, but to do that it needs libffi. It doesn't have that, so it errors out and doesn't build. FFS is OK with that, it has it's own substitute if it can't get DCG, but something is going wrong with the logic somehow. But anyhow, there's no appropriate path to set for DILL because it doesn't build here. Looking at this again, it's still not getting past ffs, so the EVPath mods are inoperative. I've added some diagnostic output to the ADIOS PR. Can you retrigger? |
|
Thank you, refreshed the patch: openPMD/openPMD-api#1833 |
|
I'm not seeing the output that I should see from the diagnostics. After it says: " -- ADIOS2 ThirdParty: Configuring ffs", the next line should be either: "ADIOS2 FFS: DID NOT FIND dill::dill target, setting FFS_USE_DILL to OFF" or "ADIOS2 FFS: found dill::dill target, setting FFS_USE_DILL to ON". Neither appears. Possible that something is going wrong with the patching? Or CI caching? |
|
Def had an issue with applying the patch, but now it works 🎉 Your patch overcomes the issue! Sorry for fumbling the patch initially. |
|
Excellent! |
|
Sadly, it looks like it needs the EVPath changes, too to find DILL. |
|
Ugh. Unfortunate. I’ve put those changes into EVPath master. The only question is whether we or not we want to pull all the recent changes to the GTkorvo stack into release_211 or just patch it. In the meantime, I’ll try to get it all into master.
From: Axel Huebl ***@***.***>
Date: Tuesday, January 27, 2026 at 2:25 PM
To: ornladios/ADIOS2 ***@***.***>
Cc: Eisenhauer, Greg S ***@***.***>, Mention ***@***.***>
Subject: Re: [ornladios/ADIOS2] Fix MacOS Static build without FFI (PR #4820)
[https://avatars.githubusercontent.com/u/1353258?s=20&v=4]ax3l left a comment (ornladios/ADIOS2#4820)<#4820 (comment)>
Sadly, it looks like it needs the EVPath changes, too to find DILL.
—
Reply to this email directly, view it on GitHub<#4820 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHF7GOZ3I5EHF6R533VEKT4I63S5AVCNFSM6AAAAACS6RGPKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBXGA4DQNBRGI>.
You are receiving this because you were mentioned.
|
* ADIOS2: 2.11.0 & Campaigns Update ADIOS2 to v2.11.0 and enable campaign management. * openPMD-api: 0.17.0 * macOS 13 -> 14/15 GH runners EOL and removed * Build SQLite3 - [x] Linux/macOS - [x] Windows * Windows h_errno patch * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * GTKorvo patch * Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks" This reverts commit 3ef0b01. * Exclude patches from pre-commit * Wrong path.. * Use a better patch for GTKorvo upstream * Fix Windows paths * Debug error * tmp: Use master branch of ADIOS2 * more paths * Try Greg's suggestion * Unix: `-DFFS_USE_DILL=FALSE` * Ouch * Ouch * Try fixing paths again.. * use downloaded patch.. * [Patch] ADIOS macOS DILL Trying ornladios/ADIOS2#4820 * Refresh ADIOS Patch w/ Diagnostics * Patch? * Patch? * Patchy patch * MACOSX_DEPLOYMENT_TARGET: 14.0/15.0 libcrypto.3.dylib and libssl.3.dylib pull this up * "git am" committer * Patch Cleanup/Simplify * macOS: keep master commit w/ EVPath Change * remove stray change --------- Co-authored-by: Franz Pöschel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Closing as redundant - the changes in this PR are included in #4817 |
2 participants
No description provided.