Issue #535: Assign fake ctid only when PK is not ctid#549
Merged
Conversation
za-arthur
force-pushed
the
issue_535_analyze_detoast
branch
from
b32369b to
b54d399
Compare
za-arthur
changed the title
orioledb_acquire_sample_rows() assings fake ctid to slot->tts_tid, ExecCopySlotHeapTuple() reads all attributes of tuples and copies them to rows array as HeapTuple by calling tts_orioledb_getsomeattrs(). tts_orioledb_getsomeattrs() also assings ctid of a tuple if it has TOAST values to detoast it later during ANALYZE. If we assign fake ctid if PK is ctid then we won't be able to detoast later.
za-arthur
force-pushed
the
issue_535_analyze_detoast
branch
from
b54d399 to
24e0dea
Compare
Pull Request Test Coverage Report for Build 17443819471Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orioledb_acquire_sample_rows()assigns fake ctid toslot->tts_tid,ExecCopySlotHeapTuple()reads all attributes of tuples and copies them to rows array asHeapTupleby callingtts_orioledb_getsomeattrs().tts_orioledb_getsomeattrs()also assigns ctid of a tuple if it has TOAST values to detoast it later during ANALYZE:orioledb/src/tuple/slot.c
Line 422 in 9c92e82
If we assign fake ctid if PK is ctid then we won't be able to detoast later.
Issue #535