-
-
Notifications
You must be signed in to change notification settings - Fork 876
feat: Force embedded ridbags when distributed #10549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Force embedded ridbags when distributed #10549
Conversation
|
What issue do you have with the tree ridbag in distributed ? do you use lightweight edges ? |
Force embedded RID bags to avoid replication errors in distributed mode. See https://orientdb.dev/docs/3.2.x/general/Concurrency.html#concurrency-when-adding-edges
182b64f to
caab146
Compare
|
Hi @tglman The number of full syncs dropped to almost zero in a distributed cluster of 3 MASTER and 2 REPLICA nodes after applying this configuration. We don't use lightweight edges (AFAIR). Scenario before applying these properties:
The full sync is very expensive for us and takes more than 30 minutes. |
|
Hi, This sounds like a bug with the integration of ridbag trees in the distributed flow, I will try to write a test case for this scenario, this may be due to the fact that changes in the ridbag tree do not change the version of the document, allowing concurrent write with other write operations, we do have some distributed scheduling to avoid concurrent writing in the same document, but maybe this check is skipped for changes in ridbag trees. Any support on reproducing the case is welcome! |
…ags, as described by PR #10549
|
Hi, I could write a somewhat minimal test case that reproduced the case and fixed it, so from the next hotfix the issue with inverted apply of distributed transaction due to ridbags tree is solved. the commit that fix it is referring to this PR. Bye |
…ags, as described by PR #10549
|
Hi, the 3.2.48 is released that should fix this case. |
|
Hi @tglman TY for the fix and release. Let's close this PR as it is not needed by itself. |
What does this PR do?
Force embedded RID bags to avoid replication errors in distributed mode.
See https://orientdb.dev/docs/3.2.x/general/Concurrency.html#concurrency-when-adding-edges
Motivation
Minimize surprises when updating large graphs in distributed mode.
Related issues
N/A
Additional Notes
N/A
Checklist
mvn clean packagecommand