fix(upload): error on upload with the same filename#258
Merged
orhun merged 1 commit intoorhun:masterfrom Mar 8, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 70.09% 70.21% +0.12%
==========================================
Files 11 11
Lines 632 638 +6
==========================================
+ Hits 443 448 +5
- Misses 189 190 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
orhun
reviewed
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently it is possible to upload files with the same name. This is undefined behavior. e.g. which file should be returned when accessing it?
To solve this problem this change introduces a check whether a file (that hasn't expired) alredy exists with the same name. If so, an error will be returned.
Motivation and Context
see #241
I am opening this PR now, because I want to check, whether the test that fails in #246 also fails with this one.
Depending on which PR is merged first, a change will be required to add an
.awaitto theglob_match_filecall.How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: