feat(server): improve random_url config handling#122
Merged
orhun merged 8 commits intoorhun:masterfrom Aug 20, 2023
Merged
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 69.47% 70.15% +0.68%
==========================================
Files 11 11
Lines 557 563 +6
==========================================
+ Hits 387 395 +8
+ Misses 170 168 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
orhun
reviewed
Aug 20, 2023
orhun
approved these changes
Aug 20, 2023
Owner
orhun
left a comment
There was a problem hiding this comment.
Thanks for the contribution once again! 💖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in order to turn random URL's off, you must have at least one
random_urldeclaration with a type and enabled =false.This PR makes the random_url config optional while deprecating the
enabledfield without breaking current configs.Motivation and Context
Closes #121
How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: