fix(server): don't log invalid token in release builds#112
Merged
orhun merged 2 commits intoorhun:masterfrom Aug 14, 2023
Merged
fix(server): don't log invalid token in release builds#112orhun merged 2 commits intoorhun:masterfrom
orhun merged 2 commits intoorhun:masterfrom
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 69.47% 69.47%
=======================================
Files 11 11
Lines 557 557
=======================================
Hits 387 387
Misses 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The server logs a sent token, if the token is not valid:
e.g.:
rpaste -a invalid_token -VThis change prints the token only in debug mode. In release mode the log entry will look like this:
Motivation and Context
fixes #111
Let's say you use rpaste with the token in the config file (or curl with the auth_token as env var or in a file), but use different rustypaste servers. If you forget only once to add the
-aflag (or add the header to curl), a production token for another instance will be logged.How Has This Been Tested?
Changelog Entry
Types of Changes
Checklist: