Revert font fallback options#76
Merged
Merged
Conversation
This reverts commit d1f86f5.
Closed
gold-silver-copper
changed the title
Owner
|
I think I'm gonna go with this either way |
orhun
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the added terminal renderer font fallback families and restores the renderer to use only the configured font family.
Why
This undoes the behavior introduced by PR #55, removing the hard-coded fallback family list from
build_terminal_renderer.Impact
Users return to the previous font selection behavior based on the configured font family and size.
Validation
cargo test